Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of properties files when they're in subdirs #1082

Merged
merged 5 commits into from
Jan 28, 2023
Merged

Fix handling of properties files when they're in subdirs #1082

merged 5 commits into from
Jan 28, 2023

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Jan 28, 2023 •
edited
Loading

  • File operation class methods create parent dirs if they don't exist
  • Avoid stripping path from file names in several places
  • Simplify prop file matching logic: check for existence of file
  • Remove list_files() method which is now unused

@rdmark rdmark marked this pull request as ready for review January 28, 2023 03:12
@rdmark rdmark mentioned this pull request Jan 28, 2023
Closed
nucleogenic
nucleogenic approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@nucleogenic nucleogenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the complexity in list_files will be missed. Super clean!
(Manually tested, all working as expected.)

@rdmark rdmark merged commit bf53958 into develop Jan 28, 2023
@rdmark rdmark deleted the rdmark-fix-nested-props branch January 28, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nucleogenic nucleogenic nucleogenic approved these changes

@akuker akuker Awaiting requested review from akuker akuker is a code owner

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdmark @nucleogenic